Skip to content

[fix](remote) fix be crash while write data to s3 in debug mode#15047

Merged
pengxiangyu merged 1 commit intoapache:masterfrom
zxealous:fix-s3-file-writer
Dec 15, 2022
Merged

[fix](remote) fix be crash while write data to s3 in debug mode#15047
pengxiangyu merged 1 commit intoapache:masterfrom
zxealous:fix-s3-file-writer

Conversation

@zxealous
Copy link
Contributor

Proposed changes

Issue Number: close #15046

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 13, 2022

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.09 seconds
load time: 434 seconds
storage size: 17123356901 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221215021310_clickbench_pr_63547.html

Copy link
Contributor

@pengxiangyu pengxiangyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pengxiangyu
pengxiangyu previously approved these changes Dec 14, 2022
Copy link
Contributor

@pengxiangyu pengxiangyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 14, 2022
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Dec 14, 2022
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@pengxiangyu pengxiangyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pengxiangyu pengxiangyu merged commit 2fcdd76 into apache:master Dec 15, 2022
@zxealous zxealous deleted the fix-s3-file-writer branch February 22, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] BE crash while write data to s3 in debug mode

3 participants